Thrift connection pool does not clean up stale connections #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derlying transport.
|
Hey this looks great @danp60 Can you sign the elasticsearch CLA: http://www.elasticsearch.org/contributor-agreement/ So I can pull the bits in, thanks! |
|
I've signed it. @Mpdreamz |
Mpdreamz
added a commit
that referenced
this pull request
Apr 7, 2014
Thrift connection pool does not clean up stale connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into this issue after doing a rolling restart. Basically what happens is that when a connection gets disconnected, the corresponding
Rest.Clientgets added back into the connection pool without the underlying connection being cleaned up.My fix simply closes the underlying connection. The next time the
Rest.Clientis used, a new connection will be opened automatically.